non-chained group invoked without subcommand invokes result callback#1621
Merged
davidism merged 1 commit intopallets:masterfrom Aug 5, 2020
Merged
Conversation
IamCathal
force-pushed
the
result-callback-invocation-1178
branch
from
95c0399 to
7b763f7
Compare
Contributor
Author
|
Rebased commits and added changelog entry |
davidism
force-pushed
the
result-callback-invocation-1178
branch
from
7b763f7 to
32ddbb1
Compare
Member
|
Changed so regular groups invoke the result callback with |
davidism
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #1178 this behavior is actually desired. I believe that the changes to the comments seem to do the job but I am not 100%. Apart from that the simple code fix I made I'm not too sure if more changes are needed else where where result callbacks are referenced.
Added a simple test to show the functionality with my addition.
fixes #1178