Don't include envvar in error hint when envvar not configured#2972
Merged
Rowlando13 merged 3 commits intopallets:stablefrom Jul 23, 2025
Merged
Don't include envvar in error hint when envvar not configured#2972Rowlando13 merged 3 commits intopallets:stablefrom
Rowlando13 merged 3 commits intopallets:stablefrom
Conversation
|
I am interested in this PR, and noticed it's still unreviewed. Is there anything that can be done to unblock this? |
Collaborator
|
@kdeldycke Would you mind reviewing this? |
Collaborator
|
Hmmm. Envvar would need a bit of refactoring right and left. I can propose something for a bigger minor/major release later. In the meantime, this PR is not wrong, solve a edge-case and adds a unit test delimiting the current behavior. So I'm good to merge it to the 8.2.2 release. |
Collaborator
|
I just fixed the merge conflict. And all tests are passing. This PR is ready to be merged into stable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a check for if
envvarisNonebefore appending to the error hint text.fixes #2971