Fix #7780, CTE flags for some functions were removed by a mistake#10768
Closed
mvorisek wants to merge 2 commits intophp:PHP-8.2from
Closed
Fix #7780, CTE flags for some functions were removed by a mistake#10768mvorisek wants to merge 2 commits intophp:PHP-8.2from
mvorisek wants to merge 2 commits intophp:PHP-8.2from
Conversation
mvorisek
changed the title
Member
|
The changes look correct to me. Thx. |
mvorisek
changed the title
mvorisek
changed the title
Contributor
Author
|
Let's merge it. |
Member
|
Unless I'm missing something, it looks like stristr was not part of the list previously, and now it is. While we can make it CTE, I believe it is strictly speaking wrong to do for non-master? |
Contributor
Author
|
given |
Member
|
While I tend to agree that it's quite silly not to do it for stripos, I don't want to make the decision by myself to also include this one in a stable release as that's not strictly speaking part of the bugfix. And I don't want to accidentally break any rules here. The other changes are fine for me. Why don't you add stripos instead to your other PR about CTE? Otherwise, we could ask someone else's opinion about stripos. |
Contributor
Author
ndossche
approved these changes
Mar 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I checked all functions from #7780
discussed here: #10729 (comment)