Fixed #69017 Fail to push to array with constant value defined in class scope#1077
Closed
reeze wants to merge 1 commit intophp:PHP-5.5from
Closed
Fixed #69017 Fail to push to array with constant value defined in class scope#1077reeze wants to merge 1 commit intophp:PHP-5.5from
reeze wants to merge 1 commit intophp:PHP-5.5from
Conversation
… class scope When updating constant key we should update nNextElement too.
Contributor
Author
|
5.5 & 5.4 have the same bug. 5.6 & master didn't have the bug because of different logic of |
Member
|
I got a better fix, committed in f2940b7 , and actually, 5.6 and master use different way handling such cases, nothing to do with zval_copy_ctor_func.. and for master, there is not update_current_key_ex at all thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.php.net/bug.php?id=69017
When updating constant key we should update nNextElement too.