Fixed bug #69174 (leaks when unused inner class use traits precedence)#1138
Closed
reeze wants to merge 3 commits intophp:PHP-5.5from
Closed
Fixed bug #69174 (leaks when unused inner class use traits precedence)#1138reeze wants to merge 3 commits intophp:PHP-5.5from
reeze wants to merge 3 commits intophp:PHP-5.5from
Conversation
This was uncovered by master's new tests: Zend/tests/assert/expect_015.php
Member
|
After reviewing, unfortunately, your fix is not fully correct and not well, first it crash with: and you introduced a new no necessary flag. I got a better fix, and committed in f039225 it also use less memory occupation. please close this PR if you have no problems. (sorry for delay, was busy with zend signals) thanks |
Contributor
Author
|
Great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was uncovered by master's new tests: Zend/tests/assert/expect_015.php
And fix the valgrind warning: https://gist.github.com/mbeccati/d4109974c5a82cf495a8