RFC: Deprecate remains of string evaluated code assertions#11671
Merged
Girgias merged 5 commits intophp:masterfrom Jul 13, 2023
Merged
RFC: Deprecate remains of string evaluated code assertions#11671Girgias merged 5 commits intophp:masterfrom
Girgias merged 5 commits intophp:masterfrom
Conversation
ndossche
approved these changes
Jul 11, 2023
Member
ndossche
left a comment
ndossche
left a comment
There was a problem hiding this comment.
There are some cases where indentation of the assert call was forgotten in the tests.
For some, like the syntax serializations, I guess that's fine to prevent lots of extra changes due to indentation.
Member
Author
Basically yes, I can fix the indentation of some of the simple ones but I didn't want the diff to be huge! |
Girgias
force-pushed
the
assert-cleanup-rfc
branch
from
61d410a to
de3156f
Compare
bukka
reviewed
Jul 13, 2023
Member
bukka
left a comment
bukka
left a comment
There was a problem hiding this comment.
Looks good in general to me. Just some minor things to address.
andypost
reviewed
Jul 14, 2023
| RFC: https://wiki.php.net/rfc/deprecations_php_8_3#mt_rand_php | ||
|
|
||
| - Standard: | ||
| . The assert_option() function is now deprecated. |
Contributor
There was a problem hiding this comment.
it should be assert_options()
arnaud-lb
added a commit
to arnaud-lb/php-src
that referenced
this pull request
Jul 16, 2023
* up/master: (571 commits) Expose time spent collecting cycles in gc_status() (php#11523) Warn when fpm socket was not registered on the expected path Implement DOMElement::id Fix ? Implement DOMParentNode::replaceChildren() Implement DOMElement::className RFC: Deprecate remains of string evaluated code assertions (php#11671) Prevent decimal int precision loss in number_format() Implement DOMNode::getRootNode() Implement DOMElement::getAttributeNames() Refactor dom_node_node_name_read() to avoid double allocation Handle fragments consisting out of multiple children without a single root correctly Avoid allocations in DOMElement::getAttribute() Avoid string allocation in dom_get_dom1_attribute() for as long as possible Fix use-of-uninitialized-value when calling php_posix_stream_get_fd (php#11694) Reorder list construction in the function php_intpow10 (php#11683) proc_open: Use posix_spawn(3) interface on systems where it is profitable zend_gdb disable gdb detection for FreeBSD < 11. Fix iface const visibility variance check Fix missing iface class const inheritance type check ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link: https://wiki.php.net/rfc/assert-string-eval-cleanup