Fix #69373 References to deleted XPath query results#1222
Closed
ttoohey wants to merge 2 commits intophp:masterfrom
Closed
Fix #69373 References to deleted XPath query results#1222ttoohey wants to merge 2 commits intophp:masterfrom
ttoohey wants to merge 2 commits intophp:masterfrom
Conversation
xmlNodeSetContentLen() calls xmlFreeNode() on node->children. This causes problems if there are other references around to those children.
Member
|
@ttoohey can you resolve conflicts and ping me directly when you have done so please |
Member
|
Having waited more than a month for this PR to be fixed, and since there are still merge conflicts, I'm closing this PR. Please take this action as encouragement to open a clean PR against an appropriate branch (must be master because ABI change). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xmlNodeSetContentLen() calls xmlFreeNode() on node->children. This causes
problems if there are other references around to those children.