ext/intl: change when the locale is invalid for the 8.1/8.2 serie.#12568
Closed
devnexen wants to merge 1 commit intophp:PHP-8.1from
Closed
ext/intl: change when the locale is invalid for the 8.1/8.2 serie.#12568devnexen wants to merge 1 commit intophp:PHP-8.1from
devnexen wants to merge 1 commit intophp:PHP-8.1from
Conversation
does not throws an exception as it's considered as a too string change, but the code user still needs to double check.
Girgias
approved these changes
Nov 1, 2023
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
I'm not a fan, but considering this breaks BC... can you add a note in UPGRADING for 8.3 when merging upwards?
|
@Girgias please <?php
$a = new IntlDateFormatter('C', IntlDateFormatter::FULL, IntlDateFormatter::FULL);
var_dump($a->getLocale(ULOC_VALID_LOCALE));
?>Result: I would expect a notice or warning but not the fatal error. Please can you explain the usage? |
Member
|
I do not understand ICU nor am I the maintainer of ext/intl, please file a new issue instead of responding to an old PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
does not throws an exception as it's considered as a too string change, but the code user still needs to double check.