Fix GH-12854: 8.3 - as final trait-used method does not correctly report visibility in Reflection#12857
Closed
ndossche wants to merge 2 commits intophp:PHP-8.3from
Closed
Fix GH-12854: 8.3 - as final trait-used method does not correctly report visibility in Reflection#12857ndossche wants to merge 2 commits intophp:PHP-8.3from
ndossche wants to merge 2 commits intophp:PHP-8.3from
Conversation
…report visibility in Reflection
Member
|
I haven't tried this branch yet, but how about the following cases? |
Member
Author
|
@SakiTakamachi Good idea to also add tests for the other way around, added a test now. |
Member
|
I see, I understand it can't change visibility and make it final at the same time. I finally got to try it local now. The warning is being output properly. |
iluuu1994
approved these changes
Dec 5, 2023
Member
iluuu1994
left a comment
iluuu1994
left a comment
There was a problem hiding this comment.
This looks correct to me. 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The message
Private methods cannot be final as they are never overridden by other classescould be improved further here to clarify it comes from traits, but not sure what to put instead...