Fix for bug #69479: GD fails to build with newer libvpx#1304
Closed
olemarkus wants to merge 1 commit intophp:masterfrom
olemarkus:master
Closed
Fix for bug #69479: GD fails to build with newer libvpx#1304olemarkus wants to merge 1 commit intophp:masterfrom olemarkus:master
olemarkus wants to merge 1 commit intophp:masterfrom
olemarkus:master
Conversation
Member
|
Notice: already fixed upstream I think master will switch soon to libwebp (from gd 2.2) so this PR have probably no interest against master. |
|
Comment on behalf of remi at php.net: applied (from gd upstream) |
Contributor
Author
|
If master switches to libwebp, this will be picked into both 5.5 and 5.6 branches? |
Member
|
@olemarkus please read "closed" comment, this have been applied (in 5.5+). Notice: bundled library should never be patched. The fix "must" go upstream first (so, in this case, should have check first, as it was already fixed in upstream library) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the contributer to this bug did not wish to create a pull request, I took the liberty of doing this for him. The same patch has been applied to downstream Gentoo and seems to work very well.