Add default value for length in mb_substr and mb_strcut#133
Closed
Irker wants to merge 1 commit intophp:masterfrom
Irker:null_default_in_mbstring
Closed
Add default value for length in mb_substr and mb_strcut#133Irker wants to merge 1 commit intophp:masterfrom Irker:null_default_in_mbstring
Irker wants to merge 1 commit intophp:masterfrom
Irker:null_default_in_mbstring
Conversation
Contributor
|
I think that this patch is valuable, and acceptable. |
Contributor
|
@Irker this fixes a long standing inconvenience, thanks. Could you add a test case? |
|
Comment on behalf of lstrojny at php.net: Merged to PHP-5.4 and master. Thanks for your contribution! |
danielbachhuber
added a commit
to wp-cli/php-cli-tools
that referenced
this pull request
Aug 4, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this commit(s) I added "null" default values for length in mb_strcut and mb_substr.
So now we can write:
$result = mb_substr("12345", 2, null, "UTF-8");
And get expected result : "345"
I added this similar to function array_slice (length parametr) php.net/manual/en/function.array-slice.php
I think no great BC there. All exist tests passed.
If you like this idea, I can add tests for my patch.
Yes, I know about mb_internal_encoding.
Yes, I know about discussion about "default" keyword.