Closed
Conversation
iluuu1994
added a commit
to iluuu1994/php-src
that referenced
this pull request
Feb 15, 2024
See discussion in php#13351. Closes phpGH-13396
iluuu1994
force-pushed
the
disable-jit-on-apple-silicon-zts
branch
from
69e5ebe to
637f1cc
Compare
See discussion in php#13351. Closes phpGH-13396
iluuu1994
force-pushed
the
disable-jit-on-apple-silicon-zts
branch
from
637f1cc to
881fe21
Compare
petk
reviewed
Feb 15, 2024
Co-authored-by: Peter Kokot <[email protected]>
dstogov
requested changes
Feb 15, 2024
Member
dstogov
left a comment
dstogov
left a comment
There was a problem hiding this comment.
The JIT disabling looks right.
The push workflow runs "Tracing JIT" tests even when JIT is disabled.
Probably nightly workflow will do the same.
Member
Author
|
@dstogov Good point. I don't plan on merging the CI changes from this PR. However, I will make the changes to nightly on |
ramsey
pushed a commit
that referenced
this pull request
Jul 3, 2025
Apple Silicon has stricter rules about rwx mmap regions. They need to be created using the MAP_JIT flag. However, the MAP_JIT seems to be incompatible with MAP_SHARED. ZTS requires MAP_SHARED so that some threads may execute code from a page while another writes/appends to it. We did not find another solution, other than completely disabling JIT for Apple Silicon + ZTS. See discussion in #13351. Co-authored-by: Peter Kokot <[email protected]> Fixes GH-13400 Closes GH-13396
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See discussion in #13351.
This will be merged into PHP 8.2. This PR targets
masterto test the change, as only themasterbranch currently includes testing for Apple Silicon.