Properly unwind stack on die/exit()'ing#1352
Closed
bwoebi wants to merge 2 commits intophp:masterfrom
Closed
Conversation
Zend/zend_exceptions.c
Outdated
Member
There was a problem hiding this comment.
This needs a corresponding free somewhere (unless I missed it?)
Alternatively could just alloc this as a global.
bwoebi
force-pushed
the
death_exception
branch
3 times, most recently
from
de9917c to
d533bb0
Compare
This uses a fake exception so that normal exception handling mechanisms can be used. The DeathException ce is never exposed to userland; it is a purely internal exception userland never has knowledge of.
Yes, session tests fail, but I think that was not really correct before... we die(), but do not really die?!
Member
|
@bwoebi can we know the status of this work please ? |
Member
|
Having waited more than a month for feedback, and having received nothing, I'm closing this PR as it would appear abandoned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses a fake exception so that normal exception handling mechanisms can be used.
The DeathException ce is never exposed to userland; it is a purely internal exception userland never has knowledge of.
One advantage is that e.g. memory leaks etc. in long-running applications can be easily found by interrupting them and die()'ing there.