Vagrant box with sqlserver express for test environment#1404
Closed
MiRacLe-RPZ wants to merge 1 commit intophp:PHP-5.5from
MiRacLe-RPZ:pdo-dblib-test-env
Closed
Vagrant box with sqlserver express for test environment#1404MiRacLe-RPZ wants to merge 1 commit intophp:PHP-5.5from MiRacLe-RPZ:pdo-dblib-test-env
MiRacLe-RPZ wants to merge 1 commit intophp:PHP-5.5from
MiRacLe-RPZ:pdo-dblib-test-env
Conversation
Member
|
The reason nobody moved on this is because it just doesn't make sense to introduce vagrant boxes to test single extensions or libraries, however elegant it may look in isolation. Since this targets an unsupported branch of PHP, and since I don't think anyone could merge a PR targeting a supported branch anyway, I'm closing this PR. It may be the case that we could make use of a vagrant box during testing, but it would have to serve a wider purpose than to test one library or extension. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.