Skip to content

Fix #53156: imagerectangle problem with point ordering#1425

Merged
php-pulls merged 2 commits intophp:masterfrom
cmb69:gd-rect-order
Jul 20, 2015
Merged

Fix #53156: imagerectangle problem with point ordering#1425
php-pulls merged 2 commits intophp:masterfrom
cmb69:gd-rect-order

Conversation

@cmb69
Copy link
Member

@cmb69 cmb69 commented Jul 20, 2015

Contrary to imagefilledrectangle(), imagerectangle() has the documented
limitation that the given points have to be the upper left and the lower right
corner, respectively. However, libgd already caters to upper right / lower left
pairs, and not catering to the other two combinations seems to be an oversight.

Reported upstream.

IMHO the patch should be applied to PHP 5.6, too. @pierrejoye @remicollet Any objections?

cmb69 added 2 commits July 20, 2015 02:14
@cmb69
Fix #53156: imagerectangle problem with point ordering
72b73e2 
Contrary to imagefilledrectangle(), imagerectangle() has the documented
limitation that the given points have to be the upper left and the lower right
corner, respectively. However, libgd already caters to upper right / lower left
pairs, and not catering to the other two combinations seems to be an oversight.
@cmb69
revised bug53156.phpt
2ec8611
@pierrejoye
Copy link
Contributor

pierrejoye commented Jul 20, 2015

Yes, making the whole thing more consistent sounds like a sane move

Thanks!
On Jul 20, 2015 7:34 AM, "Christoph M. Becker" [email protected]
wrote:

Contrary to imagefilledrectangle(), imagerectangle() has the documented
limitation that the given points have to be the upper left and the lower
right
corner, respectively. However, libgd already caters to upper right / lower
left
pairs, and not catering to the other two combinations seems to be an
oversight.

Reported upstream libgd/libgd#177.

IMHO the patch should be applied to PHP 5.6, too. @pierrejoye
https://github.com/pierrejoye @remicollet

https://github.com/remicollet Any objections?

You can view, comment on, or merge this pull request online at:

#1425
Commit Summary

  • Fix #53156: imagerectangle problem with point ordering

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHub
#1425.

@cmb69
Copy link
Member Author

cmb69 commented Jul 20, 2015

Yes, making the whole thing more consistent sounds like a sane move

Great! I'm going to merge to PHP 5.6 and master soon.

@php-pulls php-pulls merged commit 2ec8611 into php:master Jul 20, 2015
@php-pulls
Copy link

php-pulls commented Jul 20, 2015

Comment on behalf of cmb at php.net:

Merged.

@cmb69 cmb69 deleted the gd-rect-order branch July 20, 2015 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cmb69 @pierrejoye @php-pulls