hash: Add simple HashContext::__debugInfo() implementation#14644
Merged
TimWolla merged 2 commits intophp:masterfrom Jun 27, 2024
Merged
hash: Add simple HashContext::__debugInfo() implementation#14644TimWolla merged 2 commits intophp:masterfrom
TimWolla merged 2 commits intophp:masterfrom
Conversation
Girgias
approved these changes
Jun 23, 2024
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
Makes sense to me, should have an UPGRADING entry somewhere.
TimWolla
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternatively a
public readonly string $algo;could be added to the object. It would implicitly show up in the debug info output and can also be programmatically be accessed. But I'm not sure of programmatic access to just the$algois useful, without also having the flags and/or HMAC key.