Closed
Conversation
ndossche
approved these changes
Jul 3, 2024
Member
ndossche
left a comment
ndossche
left a comment
There was a problem hiding this comment.
Good catch, the modified test should catch the issue as well. Note that the test also exists on lower versions.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a race condition in https://github.com/php/php-src/blob/ec277ce7fe1e7b7f98e270198826fc1432cdcb3d/ext/openssl/tests/gh13860.phpt: If the first
fread($fp, 2);(line 36) is executed afterfwrite($client, "xx");, the test hangs indefinitely in the loop: https://github.com/php/php-src/blob/ec277ce7fe1e7b7f98e270198826fc1432cdcb3d/ext/openssl/tests/gh13860.phpt#L39C1-L41C6I've observed this on Alpine with a ZTS + ASAN build, in #13925, but adding a sleep() before the first fread() will also reproduce the issue.
Moving the
phpt_wait()beforefwrite()fixes the hang by ensuring thatfread($fp, 2);executes beforefwrite(). However I'm not sure this is still testing the right thing (although the test fails if I revert 2aae14c).