Fix GH-15123: var_dump doesn't actually work on XMLReader#15130
Fix GH-15123: var_dump doesn't actually work on XMLReader#15130ndossche merged 1 commit intophp:masterfrom
Conversation
Girgias
left a comment
There was a problem hiding this comment.
It seems a bit strange to have initialized properties when the object is actually not initialized?
Perhaps uninitialized isn't the right word. The error basically happens because you're reading a the |
|
Ah okay, yeah I think the error wording maybe should be improved then, as I thought it was similar to a DateTime object not being properly initialized |
Girgias
left a comment
There was a problem hiding this comment.
Not sure what to do about the error message, but the rest seems OK
|
What about something like "Failed to read property because no XML data has been read yet" ? |
|
I think that is indeed a better error message! :) |
Targeting master because it changes long standing behaviour, although what it currently does is useless anyway...