ext/imap/config.m4: fix conftest segfault in utf8_to_mutf7 check, bug #66909#1627
Closed
orlitzky wants to merge 1 commit intophp:masterfrom
orlitzky:fix-imap-conftest-segfault
Closed
ext/imap/config.m4: fix conftest segfault in utf8_to_mutf7 check, bug #66909#1627orlitzky wants to merge 1 commit intophp:masterfrom orlitzky:fix-imap-conftest-segfault
orlitzky wants to merge 1 commit intophp:masterfrom
orlitzky:fix-imap-conftest-segfault
Conversation
… #66909. The test program for utf8_to_mutf7 attempts to call it without arguments. The function expects one argument, however, and this leads to a segfault as reported in PHP bug #66909. The test program is using the PHP_IMAP_TEST_BUILD macro which complicates things a little. To keep this diff small, the PHP_IMAP_TEST_BUILD macro was modified to pass a fifth argument "extra-source" to the PHP_TEST_BUILD macro. The check for utf8_to_mutf7 was then modified to check for a dummy function, utf8_to_mutf7_php, which passes the correct number of arguments to utf8_to_mutf7. PHP-Bug: https://bugs.php.net/bug.php?id=66909 Gentoo-Bug: https://bugs.gentoo.org/show_bug.cgi?id=376735
|
Comment on behalf of ab at php.net: merged, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test program for utf8_to_mutf7 attempts to call it without
arguments. The function expects one argument, however, and this leads
to a segfault as reported in PHP bug #66909.
The test program is using the PHP_IMAP_TEST_BUILD macro which
complicates things a little. To keep this diff small, the
PHP_IMAP_TEST_BUILD macro was modified to pass a fifth argument
"extra-source" to the PHP_TEST_BUILD macro. The check for
utf8_to_mutf7 was then modified to check for a dummy function,
utf8_to_mutf7_php, which passes the correct number of arguments to
utf8_to_mutf7.
PHP-Bug: https://bugs.php.net/bug.php?id=66909
Gentoo-Bug: https://bugs.gentoo.org/show_bug.cgi?id=376735