Fix GH-16314 "Pdo\Mysql object is uninitialized" when opening a persistent connection#16369
Merged
kocsismate merged 1 commit intophp:PHP-8.4from Nov 5, 2024
Merged
Conversation
kocsismate
requested review from
NattyNarwhal,
SakiTakamachi and
devnexen
as code owners
kocsismate
force-pushed
the
fix-gh-16314
branch
from
c3f54df to
7cbcf7d
Compare
kocsismate
force-pushed
the
fix-gh-16314
branch
2 times, most recently
from
de4d9b0 to
1a06371
Compare
…rsistent connection
kocsismate
force-pushed
the
fix-gh-16314
branch
from
1a06371 to
ec40d2a
Compare
Member
|
@kocsismate The new test ext/pdo_mysql/tests/gh16314.phpt fails in nightly. May you have a look? |
Member
|
I can fix it right away, so will fix it! |
Member
|
Fixed |
Member
|
Thank you Saki! |
Member
Author
|
Thank you both! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes are made on top of #16167 because the two PRs touch the same code. Therefore only the last commit should be reviewed (c3f54df).