Fix bug #71525 (Calls to date_modify will mutate timelib_rel_time, causing date_date_set issues)#1753
Closed
Sean-Der wants to merge 1 commit intophp:masterfrom
Sean-Der:bug71525
Closed
Fix bug #71525 (Calls to date_modify will mutate timelib_rel_time, causing date_date_set issues)#1753Sean-Der wants to merge 1 commit intophp:masterfrom Sean-Der:bug71525
Sean-Der wants to merge 1 commit intophp:masterfrom
Sean-Der:bug71525
Conversation
timelib_time->timelib_rel_time is mutated by date_modify, and because it is never zero'ed out it latters causes other date operations to fail (like date_date_set)
Member
|
LGTM! |
Contributor
Author
|
Thanks for looking this over @derickr! This bug also effects pretty much every implementation of PHP (including HHVM) so hopefully it can be applied to 5.6 as well. |
Member
|
In the long run, I want to move all these functions into timelib, so that everything behaves the same. |
|
@Sean-Der thanks for the fix. Please merge into 7.0 (and don't forget the news). Thanks. |
|
Comment on behalf of ab at php.net: Merged with f31e0cd. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
timelib_time->timelib_rel_time is mutated by date_modify, and because it is never zero'ed out it latters causes other date operations to fail (like date_date_set)
https://bugs.php.net/bug.php?id=71525