Reflection: indicate final and abstract properties in string output#17827
Reflection: indicate final and abstract properties in string output#17827DanielEScherzer wants to merge 1 commit intophp:PHP-8.4from
Conversation
|
CC @iluuu1994 - my understanding is that final properties was added as a part of property hooks |
iluuu1994
left a comment
iluuu1994
left a comment
There was a problem hiding this comment.
Thank you! Indeed, this was missed in the implementation. This should also add abstract, which was added in the same PR. It should also target 8.4+.
DanielEScherzer
force-pushed
the
reflection-prop-final
branch
from
438de46 to
1334776
Compare
Added I didn't send this to 8.4 originally since it isn't really a bug, but retargeted. I was planning to also work on some kind of indication of property hooks in a follow-up, should that also go to 8.4? |
|
I would classify this as a bug. Whether your other PR should target 8.4 depends on whether it's a bug. 😄 |
Add "final" and "abstract" to the result of `_property_string()` when outputting the string representation of a `ReflectionClass` or `ReflectionProperty` instance
DanielEScherzer
force-pushed
the
reflection-prop-final
branch
from
1334776 to
b4f19dd
Compare
DanielEScherzer
changed the title
|
Fixed whitespace and squashed the commits |
|
Thank you @DanielEScherzer! |
2 participants
Add "final" and "abstract" to the result of
_property_string()when outputting the string representation of aReflectionClassorReflectionPropertyinstance