Closed
Conversation
tpunt
force-pushed
the
resolve-bug-72017
branch
3 times, most recently
from
98be737 to
f1552c1
Compare
tpunt
force-pushed
the
resolve-bug-72017
branch
from
f1552c1 to
bde145a
Compare
Member
|
I think it's ok. bug#72017 means bc break, we should fix it ASAP. but |
Contributor
Author
|
@tpunt i'll check anytime soon, thanks for the ping. |
|
@tpunt, merged, but having an issue closing the ticket. Will try yet tomorrow, or please you do. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves bug #72017.
This is a little hacky, but it works. It should really be noted that
range()does not work well with floats because of the precision problem.There's still cases where
range()will not work:(3v4l.)
I can't see a fix to these, however.