Fix GH-18695: float numbers zero fraction is now preserved in zend_ast_export()#18699
Merged
DanielEScherzer merged 2 commits intophp:PHP-8.3from May 29, 2025
Merged
Conversation
TimWolla
requested changes
May 29, 2025
Sannis
force-pushed
the
fix_floats_zero_fraction_in_zend_ast_export
branch
from
a395646 to
f80c4d3
Compare
Sannis
force-pushed
the
fix_floats_zero_fraction_in_zend_ast_export
branch
from
f80c4d3 to
59a3754
Compare
TimWolla
approved these changes
May 29, 2025
DanielEScherzer
approved these changes
May 29, 2025
Member
|
@TimWolla I'm happy to handle merging this if you want, otherwise deferring to you |
Member
|
Don't currently have a development environment handy, feel free to handle it. |
Member
Member
|
@DanielEScherzer NEWS in master is for master-only changes only, thus it should not be updated when merging upwards. I'll remove the entry (since that's easy to do via the GH UI). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #18695.
After this patch, there are no more
smart_str_append_double()calls withzero_fraction=false.However I didn't remove it, as this is a part of public API for extensions as I understand.