fix bug 69587 (DateInterval properties and isset)#1877
fix bug 69587 (DateInterval properties and isset)#1877jhdxr wants to merge 3 commits intophp:masterfrom
Conversation
|
It seems that the CI is broken for something else. |
|
I rebased master onto this pr, and the cr passed now. |
ext/date/php_date.c
Outdated
| return retval; | ||
| } | ||
|
|
||
| zval rv; |
There was a problem hiding this comment.
This is still not at the top, is it?
There was a problem hiding this comment.
The zval rv still does not seem at the top.
|
Ping me when you're ready so I can have a review too please. |
|
hi, @derickr how's the review going? |
|
Code looks fine to me. |
|
It looks like the |
|
Yup, but I can fix that when merging the PR ;-) |
| ZVAL_COPY(&tmp_member, member); | ||
| convert_to_string(&tmp_member); | ||
| member = &tmp_member; | ||
| cache_slot = NULL; |
There was a problem hiding this comment.
you could you zval_get_string like: https://github.com/php/php-src/blob/master/Zend/zend_object_handlers.c#L706
There was a problem hiding this comment.
well, I just followed the way converting strings in this file, should I replace them as well?
btw, it seems lxr.php.net is down for serveral days, is there any alternative?
There was a problem hiding this comment.
hmm, then nevermind, both way are right.
|
Merged. |
|
I guess this have also fixed https://bugs.php.net/bug.php?id=67621 |
8 participants
fix bug 69587
there are some related bugs, and I'm working on them.