ext/intl: Refactor error handling#19196
Merged
Girgias merged 1 commit intophp:masterfrom Jul 30, 2025
Merged
Conversation
Girgias
force-pushed
the
intl-use-exception-mechanism-rather-than-custom
branch
from
5668114 to
d825e0d
Compare
Girgias
force-pushed
the
intl-use-exception-mechanism-rather-than-custom
branch
2 times, most recently
from
5c1a24b to
854f1ae
Compare
Member
|
I appreciate the heap allocations savings ; I ll have a better look later this week. Are you still working on it though (W.I.P) ? |
Girgias
changed the title
Member
Author
Forgot to update the title of the PR, but I think I'm done modifying the C/C++ code, might work on the tests to get rid of the usage of warnings as the |
Girgias
force-pushed
the
intl-use-exception-mechanism-rather-than-custom
branch
from
854f1ae to
e79b570
Compare
xabbuh
added a commit
to symfony/symfony
that referenced
this pull request
Aug 1, 2025
….5 (xabbuh) This PR was merged into the 7.3 branch. Discussion ---------- [Translation] account for error message changes in PHP 8.5 | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT related to php/php-src#19196, following #61300 Commits ------- 4cbcf78 account for error message changes in PHP 8.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a comprehensive refactoring of the error mechanism of the Intl extension.
By moving the prefixing of the current method/function being executed to actual error message creation by accessing the execution context, we get the following benefits:
copyMsgarg becomes unused, meaning we can reduce the size of theintl_errorstruct by 4 bytes.char*across multiple calls