Fix GH-19197: session build fails on system with memcpy as macro.#19198
Merged
devnexen merged 1 commit intophp:masterfrom Jul 21, 2025
Merged
Fix GH-19197: session build fails on system with memcpy as macro.#19198devnexen merged 1 commit intophp:masterfrom
devnexen merged 1 commit intophp:masterfrom
Conversation
Thus ZEND_STRL macro does not expand as expected so going back to not using it like lower branches.
ndossche
approved these changes
Jul 21, 2025
Member
ndossche
left a comment
ndossche
left a comment
There was a problem hiding this comment.
TIL memcpy can be implemented as a macro
Member
Same, might need to check all usages of |
Member
Author
I do not think there is any left, nor do I know if any libc/os implements strncmp as macro but in case you might roll back this one if you wish. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thus ZEND_STRL macro does not expand as expected so going back to not using it like lower branches.