Fix GH-16993: Fix filter_var_array to warn when validation filters are incorrectly combined with FILTER_NULL_ON_FAILURE flag#19660
Merged
alexandre-daubois merged 1 commit intophp:masterfrom Sep 8, 2025
Conversation
iluuu1994
reviewed
Sep 2, 2025
alexandre-daubois
force-pushed
the
filter-warning-inv-usage
branch
2 times, most recently
from
d2c7be7 to
241c25b
Compare
iluuu1994
approved these changes
Sep 3, 2025
Member
iluuu1994
left a comment
iluuu1994
left a comment
There was a problem hiding this comment.
LGTM! Though I think new warnings should go to master. In that case, you'll need to ping release managers.
Member
Author
|
Works for me, it would make more sense I think. WDYT @php/release-managers-85? |
DanielEScherzer
approved these changes
Sep 7, 2025
Member
DanielEScherzer
left a comment
DanielEScherzer
left a comment
There was a problem hiding this comment.
RM approval for 8.5, no technical review performed
alexandre-daubois
force-pushed
the
filter-warning-inv-usage
branch
from
241c25b to
f717f2f
Compare
Member
Author
|
I rebased on master. Friendly ping @iluuu1994, can you double-check with the rebase just to be sure, please? |
iluuu1994
reviewed
Sep 8, 2025
Member
iluuu1994
left a comment
iluuu1994
left a comment
There was a problem hiding this comment.
Must've missed the test description in the last review.
Rebase looks good. If you squash & merge via GitHub UI nothing can go wrong in that regard anyway. 🙂 If you merge locally, git merge --ff-only can provide some confidence as well.
… are incorrectly combined with FILTER_NULL_ON_FAILURE flag
alexandre-daubois
force-pushed
the
filter-warning-inv-usage
branch
from
f717f2f to
b69b919
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #16993