Closed
Conversation
This patch addresses https://bugs.php.net/bug.php?id=72409 It does alter default behavior in a potentially BC-incompatable means. In the event someone was === true, the return value of pcntl_signal(). However, this change could be applied to master with small changes. This patch is applied to master compared to PR#1952 which was patching 5.6.x branch of PHP
Contributor
|
I'm not opposed to the BC break, but for consideration to address the breakage, a new function that returns the current handler assignment ( |
Member
|
After some discussion, I think a better direction would be an additional function, @weltling Would it be acceptable to add this function to 7.0 as well? |
Per comments on this bug-fix, I have added a new function to get the currently defiend signal handler. In doing so we need to change pcntl_signal to store the long value if a user uses \SIG_DFL or \SIG_IGN. If unset, \SIG_DFL is returned.
Contributor
Author
|
Should this function be in-addition-to, or instead of returning the old-act form pcntl_signal? |
Member
|
@bp1222 Instead of returning the old value from |
Member
|
@bp1222 Can you open a clean PR with just what's needed for the getter function? Then this can be merged. |
Contributor
Author
|
Will do. Closing this one now, will submit new in a bit. |
bp1222
added a commit
to bp1222/php-src
that referenced
this pull request
Jul 5, 2016
This patch addresses https://bugs.php.net/bug.php?id=72409 This patch is applied to master compared to PR#1952 which was patching 5.6.x branch of PHP This patch takes into account discussions on PR php#1978 Addressing that rather than have pcntl_signal() return a value to create a new function that can be used to get the current value of the signal handler.
php-pulls
pushed a commit
that referenced
this pull request
Jul 6, 2016
This patch addresses https://bugs.php.net/bug.php?id=72409 This patch is applied to master compared to PR#1952 which was patching 5.6.x branch of PHP This patch takes into account discussions on PR #1978 Addressing that rather than have pcntl_signal() return a value to create a new function that can be used to get the current value of the signal handler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch addresses https://bugs.php.net/bug.php?id=72409
It does alter default behavior in a potentially BC-incompatable
means. In the event someone was === true, the return value
of pcntl_signal(). However, this change could be applied to
master with small changes.
This patch is applied to master compared to PR #1952 which was
patching 5.6.x branch of PHP