Fix for bug #72496 - Child method with different signature from parent private method#1980
Closed
pmmaga wants to merge 1 commit intophp:PHP-5.6from
Closed
Fix for bug #72496 - Child method with different signature from parent private method#1980pmmaga wants to merge 1 commit intophp:PHP-5.6from
pmmaga wants to merge 1 commit intophp:PHP-5.6from
Conversation
Member
|
Thanks for basing on 5.6. The PR looks good to me. @nikic As you've commented positively on the bug report: can this be merged, or does it need further discussion on internals? |
Member
|
@cmb69 It can be merged. Don't think there's anything controversial here. |
Member
|
@nikic Fine. I can't merge, however, due to insufficient karma. FWIW, the respective changes for PHP 7.0 would be: |
Contributor
Author
|
@cmb69, I actually started by fixing it on master. Besides the change being now on inheritance there is also another test that needs a fix. You can check my changes: master...pmmaga:bug-72496 |
Member
|
Ah, thanks, @pmmaga! I had missed that. |
Member
|
Merged as 08777e9 into 5.6 and upwards. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an implementation of a child method has the same name as a private parent method, their signatures are checked for compatibility.
This shouldn't be the case as if the parent's method is private, the child's method is not overriding it.
Link for the bug: https://bugs.php.net/bug.php?id=72496
This PR replaces #1971 which was made against 5.5