Bug #62479 Fix bug where spaces in passwords would fail#199
Closed
willfitch wants to merge 3 commits intophp:masterfrom
willfitch:bug-62479
Closed
Bug #62479 Fix bug where spaces in passwords would fail#199willfitch wants to merge 3 commits intophp:masterfrom willfitch:bug-62479
willfitch wants to merge 3 commits intophp:masterfrom
willfitch:bug-62479
Conversation
Change-Id: I53679937d69b0a8897961900ebf33d197b8ce018
Contributor
|
Thanks! We need a test for that. |
Contributor
Author
|
Test added @lstrojny |
Member
|
Maybe @iliaal want to have a look,he is the official maintainer. |
Contributor
|
I think the patch inside http://ilia.ws/patch/pdo.txt maybe better, as it also accounts for the possibility of the password containing \ character. |
Contributor
|
@iliaal will you merge your patch and close this PR? |
Contributor
|
@iliaal ping |
Contributor
|
@willfitch any news? |
|
Comment on behalf of stas at php.net: Looks like this one is abandoned. Since Ilia thinks different patch is better, closing this one. |
Contributor
Author
|
Where did this go? Just trying to see if @iliaal's patch made it in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: I53679937d69b0a8897961900ebf33d197b8ce018