Fix GH-20217: ReflectionClass::isIterable() should return false for classes with property hooks#20241
Merged
alexandre-daubois merged 1 commit intophp:PHP-8.4from Oct 22, 2025
Conversation
Member
|
It's worth noting this has some impact on other internal classes that set |
Member
Author
|
As it only reported to cause problems with hooks, I'd say 8.4 is the right target? |
Member
|
There are other classes with |
iluuu1994
reviewed
Oct 20, 2025
d859219 to
c7c2017
Compare
DanielEScherzer
approved these changes
Oct 21, 2025
iluuu1994
reviewed
Oct 21, 2025
c7c2017 to
d13e220
Compare
…r classes with property hooks
d13e220 to
69327e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.