substr_compare: Ignore length parameter if NULL#2052
Closed
Metabolix wants to merge 1 commit intophp:PHP-7.0from
Closed
substr_compare: Ignore length parameter if NULL#2052Metabolix wants to merge 1 commit intophp:PHP-7.0from
Metabolix wants to merge 1 commit intophp:PHP-7.0from
Conversation
Make substr_compare ignore the length if it's NULL. This allows to use the last parameter (case_insensitivity) with the default length. Fixes bug #55451.
Metabolix
force-pushed
the
php70-fix-55451
branch
from
b7bae73 to
5b6f306
Compare
Member
|
Merged as e616bc8 into 7.0 and up. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make substr_compare ignore the length if it's NULL. This allows to use the last parameter (case_insensitivity) with the default length. Fixes bug #55451.