Avoid use of scratch space in HTTP fopen wrapper#2054
Closed
nikic wants to merge 1 commit intophp:masterfrom
Closed
Avoid use of scratch space in HTTP fopen wrapper#2054nikic wants to merge 1 commit intophp:masterfrom
nikic wants to merge 1 commit intophp:masterfrom
Conversation
Instead directly write into req_buf smart_str.
Contributor
|
Looks good to me, though it does have a slight impact on readability where slprintf/snprintf used to be. |
Member
Author
|
Merged via 3823bfc. Thanks for taking a look. Yeah, readability is a bit worse than printf, but I think this is more robust (no magic allocation buffers of size 29 (why?)) and avoids a couple of extra copies between buffers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead directly write into req_buf smart_str.