Fix #69267 (partially): mb_strtolower fails on titlecase characters#2148
Closed
zfigura wants to merge 2 commits intophp:masterfrom
zfigura:master
Closed
Fix #69267 (partially): mb_strtolower fails on titlecase characters#2148zfigura wants to merge 2 commits intophp:masterfrom zfigura:master
zfigura wants to merge 2 commits intophp:masterfrom
zfigura:master
Conversation
Member
|
Can we know the current status of this patch ? I don't know how to find out what action was taken by openldap, and it's not clear if we need to do anything ? |
Author
|
openldap has not taken any action yet. I don't know how or when this file was copied from them, so it is not clear to me either. |
Member
|
Looking through OpenLDAP commit log, this looks like the corresponding patch for this issue on their side, though using a different implementation: https://www.openldap.org/devel/gitweb.cgi?p=openldap.git;a=commitdiff;h=60a25c72ba389f53b0621ca250bc99f3b295d43f |
Member
|
I think best to wait for the version of oldap with these changes included to propagate, rather than make changes here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes a simple arithmetical error.
This is a partial fix. The characters Dž, Lj, Nj, Dz will now be converted appropriately. However, Greek characters with hypogegrammene still do not work. This is because they are not generated by ucgendat.c as title-case characters, but rather as upper-case characters. Since this file originates in OpenLDAP, I have submitted a patch there. I don't know what the proper way is to propagate that change here, however, assuming it is accepted.