Fix blob parameters binding. Fixes: #73087, #61183, #71494#2183
Closed
madorin wants to merge 3 commits intophp:masterfrom
madorin:master
Closed
Fix blob parameters binding. Fixes: #73087, #61183, #71494#2183madorin wants to merge 3 commits intophp:masterfrom madorin:master
madorin wants to merge 3 commits intophp:masterfrom
madorin:master
Conversation
weltling
reviewed
Nov 4, 2016
| case SQL_BLOB: | ||
| case SQL_BLOB: { | ||
| if (Z_TYPE_P(parameter) == IS_NULL) { | ||
| // Check if this field allow NULL values |
weltling
reviewed
Nov 4, 2016
| } | ||
|
|
||
| zval_dtor(param); | ||
| if (Z_TYPE_P(param) != IS_STRING) |
There was a problem hiding this comment.
Please use curly brackets as well, see http://git.php.net/?p=php-src.git;a=blob_plain;f=CODING_STANDARDS;hb=HEAD .
Thanks.
|
A test is requiered, please add one based on a snippets from tickets. Thanks. |
Contributor
Author
|
Added test case to reproduce bug #73087 |
|
Merged via 3d73f71. Thanks! |
Contributor
Author
|
Anatol, please close also #61895. |
mariuz
added a commit
to mariuz/yii2-firebird
that referenced
this pull request
Nov 9, 2016
Fixed by this pull request php/php-src#2183 Thanks to @madorin
This was referenced Nov 9, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review someone more initiated in PHP, PDO code.
This fix an old frustrating bug in blob param binding.
Also include proper handling when NULL is passed.