Fix Bug #73462 - Persistent connections don't set $connect_errno#2193
Closed
darkain wants to merge 2 commits intophp:PHP-5.6from
darkain:patch-5
Closed
Fix Bug #73462 - Persistent connections don't set $connect_errno#2193darkain wants to merge 2 commits intophp:PHP-5.6from darkain:patch-5
darkain wants to merge 2 commits intophp:PHP-5.6from
darkain:patch-5
Conversation
Persistent connections skipped resetting $connect_error and $connect_errno values This adds the "clear error" line to persistent connections for consistency
Contributor
Author
|
The failed Travis CI test is in unrelated code, specifically the FTP extension because a TCP port was already in use on the automated testing server. Not sure if there is an easy way to just re-run the test to show it is actually passing, or mark the failed test as irrelevant to the pull request here? |
Contributor
|
You can squash your commits which should also trigger a new run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Persistent connections skipped resetting $connect_error and $connect_errno values
This adds the "clear error" line to persistent connections for consistency