Fix Bug #73462 - Persistent connections don't set $connect_errno#2195
Fix Bug #73462 - Persistent connections don't set $connect_errno#2195darkain wants to merge 3 commits intophp:PHP-5.6from darkain:PHP-5.6
Conversation
Persistent connections skipped resetting $connect_error and $connect_errno values This adds the "clear error" line to persistent connections for consistency
|
The Travis CI environment is entirely unpredictable. Just pushed in a commit of just white-space change to the markdown file, and all compilation tests passed this time, vs failing randomly and arbitrarily before. |
|
@darkain don't bother too much with Travis, I stopped caring much about it a while ago since as you mentioned, is way too inconsistent |
|
this bugfix need a test, to be sure that it works fine. |
The connection is now verified to be persistent when. If the connection isn't persistent, then the bug wouldn't present itself anyways.
|
Comment on behalf of krakjoe at php.net: adding label |
|
Since this targets a security fix only branch of PHP, and since the author seems to have abandoned working on it anyway, I'm closing this PR. Please take this action as encouragement to open a clean PR against a supported branch. |
|
Doesn't look abandoned to me... |
|
Also it appears to apply cleanly to master at least ... I'm sure I checked that ... my mistake ... |
|
Merged via cfd6e14, thanks! |
6 participants
Persistent connections skipped resetting $connect_error and $connect_errno values
This adds the "clear error" line to persistent connections for consistency