Fix Bug 73478: openssl_pkey_new() should not generate a new public/pr…#2197
Fix Bug 73478: openssl_pkey_new() should not generate a new public/pr…#2197mhagstrand wants to merge 1 commit intophp:masterfrom
Conversation
mhagstrand
force-pushed
the
BUG73478
branch
2 times, most recently
from
dca25ca to
69f46f8
Compare
|
cc @bukka |
…ivate key pair for DH when the private key is provided Also DSA_generate_key cannot generate the public key from the private in php_openssl_pkey_init_dsa
|
Unfortunately this is no longer supported in OpenSSL 1.1 so I'm not too keen to add just for 1.0 as it will create difference that we can't fix. Please see (you can't supply an empty public key). The DH part won't set the key too in OpenSSL 1.1 for the the similar reason. So it would again lead to a different result. |
|
Yeah, that is really good point. I didn't realize it would not work in OpenSSL 1.1. I'm going to close this PR. Thanks |
|
@bukka this will introduce a BC break for people using PHP 7.1 and OpenSSL 1.0.x. For instance, Ubuntu 16 offers OpenSSL 1.0.2g as default. I think we should trigger a warning or a deprecation notice if someone will pass a |
4 participants
…ivate key pair for DH when the private key is provided
Also DSA_generate_key cannot generate the public key from the private in php_openssl_pkey_init_dsa