Skip to content

Fix #73585: Logging of "Internal Zend error" missing class name #2219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mhagstrand wants to merge 1 commit into from
Closed

Fix #73585: Logging of "Internal Zend error" missing class name #2219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Zend/zend_compile.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1084,7 +1084,11 @@ ZEND_API int do_bind_function(const zend_op_array *op_array, const zend_op *opli
rtd_key = lcname + 1;
}

function = zend_hash_find_ptr(function_table, Z_STR_P(rtd_key));
if ((function = zend_hash_find_ptr(function_table, Z_STR_P(rtd_key))) == NULL) {
zend_error_noreturn(E_COMPILE_ERROR, "Internal Zend error - Missing information for function %s", Z_STRVAL_P(lcname));
return FAILURE;
}

new_function = zend_arena_alloc(&CG(arena), sizeof(zend_op_array));
memcpy(new_function, function, sizeof(zend_op_array));
if (zend_hash_add_ptr(function_table, Z_STR_P(lcname), new_function) == NULL) {
Expand Down Expand Up @@ -1125,7 +1129,7 @@ ZEND_API zend_class_entry *do_bind_class(const zend_op_array* op_array, const ze
rtd_key = lcname + 1;
}
if ((ce = zend_hash_find_ptr(class_table, Z_STR_P(rtd_key))) == NULL) {
zend_error_noreturn(E_COMPILE_ERROR, "Internal Zend error - Missing class information for %s", Z_STRVAL_P(rtd_key));
zend_error_noreturn(E_COMPILE_ERROR, "Internal Zend error - Missing information for class %s", Z_STRVAL_P(lcname));
return NULL;
}
ce->refcount++;
Expand Down