Closed
Conversation
Contributor
|
Could you please mark the test as XFAIL? Thanks. |
Contributor
Author
|
@lstrojny heya, what exactly do you mean by |
Contributor
Author
|
To be more clear, I think that Ocramius:issue/bug-63462 should only be merged into a branch that already contains the fix |
Contributor
|
@Ocramius XFAIL is a section that allows committing failing tests without failing the build |
Contributor
Author
|
Will do ASAP then |
Contributor
|
One last thing: could you squash the commits into one? |
Contributor
Author
|
@lstrojny done |
|
Comment on behalf of lstrojny at php.net: Merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a failing test for bug 63462.
Any access to private/protected properties that were unset triggers
__get,__setor__issettwice.This does not happen with public or non-existing properties though.