Fixed #73959 - pgsql - lastInsertId fails to throw an exception for wrong sequence name#2325
Closed
andrewnester wants to merge 1 commit intophp:PHP-7.0from
Closed
Fixed #73959 - pgsql - lastInsertId fails to throw an exception for wrong sequence name#2325andrewnester wants to merge 1 commit intophp:PHP-7.0from
andrewnester wants to merge 1 commit intophp:PHP-7.0from
Conversation
Contributor
Author
|
@krakjoe quick question - should I send PR to master like I did or to PHP-7.0 |
Member
|
This doesn't merge cleanly into 7.0, generally bug fixes - without bc breaks - should target the lowest applicable branch. If higher branches require a different patch, open a PR for those. I'll wait for patches for lower branches, ping me when ready ;) |
andrewnester
force-pushed
the
73959-last-insert-id-pgsql
branch
from
02a6f2e to
dfb0e8c
Compare
Contributor
Author
|
@krakjoe Hi again! just rebased my PR to |
Member
|
Merged 21ac79e Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://bugs.php.net/bug.php?id=73959
Caused by 90c6cbd#diff-b62143c40851ff103819b192f4225110R378