FR #74217 - Allow creation of deterministic sqlite functions#2412
Closed
andrewnester wants to merge 2 commits intophp:masterfrom
Closed
FR #74217 - Allow creation of deterministic sqlite functions#2412andrewnester wants to merge 2 commits intophp:masterfrom
andrewnester wants to merge 2 commits intophp:masterfrom
Conversation
Contributor
Author
|
@krakjoe I suppose it requires proper RFC, am I right? |
Member
|
Would be a nice addition for ext/sqlite3, too! |
Contributor
Author
Member
|
@andrewnester Ah, I've overlooked that, because I thought its about PDO_sqlite only! IMHO this doesn't need an RFC. It's a small, self-contained addition, and it's usefulness doesn't appear to be contentious. Anyhow, I'm +1 on this. |
Contributor
Author
|
Travis failure says |
krakjoe
changed the title
Member
|
No RFC is necessary. LGTM, let's just wait for CI ... |
nikic
reviewed
Mar 10, 2017
| --EXPECTF-- | ||
| array(2) { | ||
| ["testing(name)"]=> | ||
| %string|unicode%(3) "php" |
krakjoe
reviewed
Mar 10, 2017
| ?> | ||
| --EXPECTF-- | ||
| bool(true) | ||
| %string|unicode%(4) "TEST" |
krakjoe
reviewed
Mar 10, 2017
ext/sqlite3/sqlite3.c
Outdated
| ZEND_END_ARG_INFO() | ||
|
|
||
| ZEND_BEGIN_ARG_INFO_EX(arginfo_sqlite3_createfunction, 0, 0, 2) | ||
| ZEND_BEGIN_ARG_INFO_EX(arginfo_sqlite3_createfunction, 0, 0, 3) |
Member
There was a problem hiding this comment.
This is not a required argument.
Contributor
Author
Member
|
@krakjoe Can this go into 7.1? |
Member
|
@nikic fine for 7.1 |
Member
|
Merged via fbf0e05 into 7.1+. |
salathe
pushed a commit
to salathe/phpdoc-en
that referenced
this pull request
Mar 17, 2017
See php/php-src#2412. git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@342155 c90b9560-bf6c-de11-be94-00142212c4b1
LawnGnome
pushed a commit
to LawnGnome/phpdoc-en
that referenced
this pull request
Mar 17, 2017
See php/php-src#2412. git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@342155 c90b9560-bf6c-de11-be94-00142212c4b1
svn2github
pushed a commit
to svn2github/phpdoc_en
that referenced
this pull request
Mar 17, 2017
See php/php-src#2412. git-svn-id: http://svn.php.net/repository/phpdoc/en@342155 c90b9560-bf6c-de11-be94-00142212c4b1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added ability to pass flags to
sqlite3_create_functioncalls.Based on https://bugs.php.net/bug.php?id=74217