Bug #61970 - Allow a child class to restrict access to ctor#2413
Closed
pmmaga wants to merge 2 commits intophp:masterfrom
Closed
Bug #61970 - Allow a child class to restrict access to ctor#2413pmmaga wants to merge 2 commits intophp:masterfrom
pmmaga wants to merge 2 commits intophp:masterfrom
Conversation
pmmaga
force-pushed
the
bug-61970
branch
3 times, most recently
from
3e68c04 to
bea8d2d
Compare
Member
|
How does this handle the case where the ctor is specified in a interface / abstract method? |
Contributor
Author
|
Thanks for the heads up. I was lifting the restriction for those as well. I've fixed it and added tests to cover those cases. |
nikic
approved these changes
May 1, 2017
Member
|
Merged as 5324fb1 into master, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A child class should be able to restrict visibility on the constructor. Given that the number of required parameters is already not enforced, I believe the visibility should also not be enforced.
Link for bugsnet: https://bugs.php.net/bug.php?id=61970
This doesn't cause any BC break as it is lifting a current restriction.