ext/filter support for validating MAC addresses.#247
ext/filter support for validating MAC addresses.#247mj wants to merge 3 commits intophp:masterfrom mj:filter-validate-mac
Conversation
|
Looks good! |
|
I probably misunderstood something, but why is this using |
|
nikic, the |
|
I think we need an RFC for that anywy. @nikic what do you think? |
|
I think an RFC is too much for this small addition, but it would be nice to at least bring this up on internals ;) |
|
Alright, @mj could you bring that up on Internals with something like "if no one objects it’s gonna be merged in a week". |
|
A flag for specifying the valid format would be useful. |
|
Also, a no-delimiter format might also be useful. :) |
|
@mj as you said, you have anough karma. Go ahead. But please don't forget to squash the commits first. |
|
Wouldn't the separator characters and/or formats be better off as flags? |
|
ping @mj |
|
I'm pretty busy at the moment but will look into it ASAP. |
|
Has been merged. |
This PR adds support to ext/filter to validate MAC addresses. It partially implements the feature request from bug #49180.