zend_compile_try: fix memory reallocation handling in multi-catch#2481
Closed
matej21 wants to merge 1 commit intophp:masterfrom
Closed
zend_compile_try: fix memory reallocation handling in multi-catch#2481matej21 wants to merge 1 commit intophp:masterfrom
matej21 wants to merge 1 commit intophp:masterfrom
Conversation
Contributor
Author
|
other possible solution is to switch that two lines and add 1 to get_next_op_number; like that: opline->extended_value = get_next_op_number(CG(active_op_array)) + 1;
jmp_multicatch[j] = zend_emit_jump(0);but that assumes that zend_emit_jump will produce exactly one opline, so I'm not sure about it.. |
Member
|
Merged as 2135b05. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes bug https://bugs.php.net/bug.php?id=74444
zend_emit_jump(0);may cause memory reallocation so we need to get opline againthis is my first php-src PR so I hope it is ok :)