Fixed #74639 - Added proper clone functionality for DatePeriod and DateInterval#2542
Closed
andrewnester wants to merge 2 commits intophp:PHP-7.1from
Closed
Fixed #74639 - Added proper clone functionality for DatePeriod and DateInterval#2542andrewnester wants to merge 2 commits intophp:PHP-7.1from
andrewnester wants to merge 2 commits intophp:PHP-7.1from
Conversation
Contributor
|
/cc @derickr |
derickr
approved these changes
May 30, 2017
Member
derickr
left a comment
derickr
left a comment
There was a problem hiding this comment.
LGTM, although I would modify the test case as per comment.
ext/date/tests/bug74639.phpt
Outdated
| <?php | ||
|
|
||
| $start = new DateTime('2017-05-22 09:00:00', new \DateTimeZone('Europe/Berlin')); | ||
| $end = new DateTime('2017-08-24 18:00:00', new \DateTimeZone('Europe/Berlin')); |
Member
There was a problem hiding this comment.
Instead of hard coding the timezone here, I would have put that in an --INI-- setting and used UTC.
Contributor
Author
There was a problem hiding this comment.
@derickr thanks! to be fair we don't need to set timezone in this test at all. So I removed it, thanks
Contributor
Author
|
@krakjoe any conclusion on this? |
Member
|
Merged 48598a2 Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for https://bugs.php.net/bug.php?id=74639
Implemented clone functionality for
DatePeriodandDateInterval.This functionality has been missed previously.