Fixes Bug #71412 Incorrect ArrayIterator __construct signature#2566
Closed
TysonAndre wants to merge 1 commit intophp:masterfrom
Closed
Fixes Bug #71412 Incorrect ArrayIterator __construct signature#2566TysonAndre wants to merge 1 commit intophp:masterfrom
TysonAndre wants to merge 1 commit intophp:masterfrom
Conversation
Member
|
This is technically BC breaking (because passing more arguments than expected is an error for internal classes), so I'd suggest landing this on master only. |
The implementation seems to be what needs to be fixed, not the documentation. ArrayIterator doesn't have a getIterator method(), or an iterator setter, and I don't think it makes sense for it to have one. (Not very familiar with this class, though) The bug **in Reflection** may have been added in 7.0.2 when fixing #71077 (The fact that the constructor was shared probably predates that)
TysonAndre
force-pushed
the
reflection-arrayiterator-php70
branch
from
927176d to
9a0f4ae
Compare
Member
|
It's not clear whether you meant for this to target 7.2 or master after the 7.2 branch @nikic ? Whatever, I'll leave this to @remicollet or @sgolemon to merge ... if one of you could take care of that, kthnx. |
Member
|
I think pulling this onto master now for alpha3 is fine. I'll try to carve out a minute to pull this before Tuesday rolls around. :D |
|
Comment on behalf of pollita at php.net: Closed by 96fe07e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation seems to be what needs to be fixed, not the
documentation.
ArrayIterator doesn't have a getIterator method(),
or an iterator setter,
and I don't think it makes sense for it to have one.
(Not very familiar with this class, though)
The bug in Reflection may have been added in 7.0.2 when fixing #71077
(The fact that the constructor was shared probably predates that)
Notes on BC: This is a constructor, so I don't expect the reflection change to break backwards compatibility.