BUG #74737: Incorrect ReflectionFunction information for mysqli_get_c…#2579
BUG #74737: Incorrect ReflectionFunction information for mysqli_get_c…#2579mhagstrand wants to merge 1 commit intophp:masterfrom
Conversation
|
According to php-src/ext/mysqli/mysqli_api.c Line 1376 in 703209f |
|
Yeah I did see that, but it can according to the docs take an optional parameter. I didn't want to make a BC breaking change in case a someone was passing in the $link parameter. |
|
Passing in additional parameters will still be supported, as the implementation does not use zend_parse_parameters_none(). |
|
So do you think I should use |
|
Yeah, that would make the most sense to me. |
|
I have made those changes. Thanks for the input. |
|
Comment on behalf of pollita at php.net: |
|
This bug is still open in https://bugs.php.net/bug.php?id=74737 |
|
@carusogabriel Thanks, closed. |
…lient_info
The $link parameter for
mysqli_get_client_infowas showing as required from reflection, but it is an optional parameter.https://bugs.php.net/bug.php?id=74737