Thanks so much - that was really quick.

Just curious - I would have checked the length of ZSTR_VAL(url->s) before grabbing ZSTR_VAL(url->s)[0] :) Little I know of course.

@csev the whole condition is url_parts->fragment && '#' == ZSTR_VAL(url->s)[0].
In case if length of url->s will be 0, url_parts->fragment will obviously be false.
So I guess no need to add one more check for this.

Did not try, but http://php.net#foo might be another problem case.

@nikic what is the expected output for this case? http://php.net?PHPSESSID=sessionidhere#foo or http://php.net#foo ?

It should be http://php.net/?PHPSESSID=sessionidhere#foo. There's code handling the !path&&!query case, but it assumes fragment is empty.

@nikic exactly! thanks, I've just updated my PR according to comments

@nikic @krakjoe any updates on this?

I'm going to assign it to nikita and ask that he merge it if he's happy with it ... he's touched and or reviewed this code recently if my memory serves me correct (which it may not) ...

Merged as 6c32d27, thanks!